[Libre-soc-bugs] [Bug 982] Support PowerPC ABI in ISACaller

[bugzilla-daemon at libre-soc.org]

https://bugs.libre-soc.org/show_bug.cgi?id=982

--- Comment #87 from Luke Kenneth Casson Leighton <lkcl at lkcl.net> ---
(In reply to Jacob Lifshay from comment #86)

> well, that doesn't work because it won't make the loop exit without
> signalling that it's done somehow...so, you can put the try-except in
> execute_one but it needs to return False or something that the caller can
> use so it knows to stop.

set a boolean flag instead. have setup_one throw KeyError.
document it and link here as part of the comments.

i don't want time wasted hunting down a change to the existing API.

> all callers need to be modified to detect that and stop looping (unless they
> don't call execute_one in a loop)

no. throw KeyError right at the start of setup_one. documented.

  65                     while index < len(instructions):
  66                         print("instr pc", pc)
  67                         try:
  68                             yield from simulator.setup_one()
  69                         except KeyError:  # instruction not in imem: stop
  70                             break
  71                         yield Settle()

-- 
You are receiving this mail because:
You are on the CC list for the bug.