[Libre-soc-bugs] [Bug 1044] SVP64 implementation of pow(x,y,z)

bugzilla-daemon at libre-soc.org bugzilla-daemon at libre-soc.org
Thu Nov 30 09:33:36 GMT 2023


--- Comment #72 from Jacob Lifshay <programmerjake at gmail.com> ---
(In reply to Luke Kenneth Casson Leighton from comment #71)
> (In reply to Jacob Lifshay from comment #70)
> > (In reply to Jacob Lifshay from comment #69)
> > > (In reply to Jacob Lifshay from comment #65)
> > > > don't rush ahead and declare everything complete before I merge...currently
> > > > running tests on rebased branch.
> > > 
> > > well, git majorly messed up the rebase, so I tried git merge which is also
> > > messed up...investigating...
> > 
> > ok, fixed it afaict, it was the LogKind -> LogType rename getting in there
> > to mess stuff up.
> (i always regularly rebase from to avoid that)
> > running tests is taking forever (8min only 1/4 completes the full powmod
> > test), 
> it'll need moving to "long" tests.

yeah, I remember it taking much less time before I rebased...

> ok i am seeing "passed" on 116 searches for "powmod" which in my 
> (not-having-been-writing-the-tests) mind seems excessive but i know
> you do very comprehensive and thorough tests so am perfectly
> happy with them.

well, it mentions each test twice, once when it starts it and once when it
finishes it. also, most of those tests are actually testing sub-pieces of
powmod, e.g. I have a pile of tests for divmod to ensure I actually hit all the
corner cases (otherwise how would I know if it's correct? it's too complex for
me to confidentially say it's bug-free without them). the few tests testing the
full powmod algorithm are the ones that take 30min.

You are receiving this mail because:
You are on the CC list for the bug.

More information about the libre-soc-bugs mailing list