[Libre-soc-bugs] [Bug 1169] Add ELF and mmap support to ISACaller -- no dynamic linking

bugzilla-daemon at libre-soc.org bugzilla-daemon at libre-soc.org
Fri Nov 17 21:20:03 GMT 2023


--- Comment #22 from Jacob Lifshay <programmerjake at gmail.com> ---
(In reply to Luke Kenneth Casson Leighton from comment #21)
> (In reply to Jacob Lifshay from comment #19)
> > Oh, i just thought of this while writing this comment, since it tracks page
> > permissions for safety reasons (so python doesn't segfault),
> this was NOT part of the scope of work.

page permissions for safety reasons were already added in bug #1173, because if
we mmap a file as read-only (remember we're calling mmap on the host to replace
part of the mmap.mmap block of memory), we need to not try to write to that
memory, otherwise python *will* segfault instead of properly reporting a test
error, majorly messing up all other test cases that that pytest worker is
trying to run. therefore I think this is necessary.

> you did not seek authorization to change the scope or priority of this work!

I did, I was told (comment #6) that I needed to increase the scope so I could
use up more of the EUR 6000

> that it is acceptable to massively increase the scope of work.

I asked andrey to check the increased scope, he said it looks fine. I started
working on mmap while waiting for you to check since that's something you
previously agreed we needed. Also, mmap makes loading ELFs easier, and is what
linux and qemu do.

> the ONLY THING needed for sign-off is read write and close.

you already agreed to more than that in comment #6 and comment #9, you're
probably confusing this with bug #982, where we were originally trying to
implement read/write/close.
> i need you to get back onto the crypto work as quickly as possible.

sorry, i had forgotten that, being distracted by fixing all the test errors on
master. The powmod work is basically done, all the rest of the stuff i recall I
said should be part of mul remap.

I do think ELF needs to be higher priority since the grant *is expiring soon*,
iirc david said we should try to finish everything off by dec and that doesn't
leave much time.

I did ask and you agreed to me working on ELF next and putting off mul remap
for later:

You are receiving this mail because:
You are on the CC list for the bug.

More information about the libre-soc-bugs mailing list