[Libre-soc-bugs] [Bug 1205] pifpstore.mdwn conflicts with fpstore.mdwn -- defines stfsu twice

[bugzilla-daemon at libre-soc.org]

https://bugs.libre-soc.org/show_bug.cgi?id=1205

Jacob Lifshay <programmerjake at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |programmerjake at gmail.com

--- Comment #2 from Jacob Lifshay <programmerjake at gmail.com> ---
(In reply to Luke Kenneth Casson Leighton from comment #1)
> (In reply to Jacob Lifshay from comment #0)
> 
> > Whoever merged that branch *needed* to have run tests first, and upon
> 
> me. i'm in absolutely no position whatsoever to be able to do that

this is why we *need* CI, because you can look at CI if you can't or don't want
to run tests locally. just push to a branch (preferably not master) and it'll
run tests for you. (which is also why it's practically necessary for it to run
shortly after pushing commits to whatever branch is being worked on, rather
than waiting 24hr)

> , as i am
> on the move routinely and will be on battery power only.  i'm collecting the
> dell
> server tomorrow and *may* be able to set it up on the UPS and a 12v WIFI
> network
> over the next week or so.

nice!
> 
> in the meantime i'll be counting on you and others in the team to catch
> things
> like this and help resolve them.
> 
> commit 9fe4ddc04c9b8f30d6efc74ce0173d385eb87f1f (HEAD -> master,
> origin/master, origin/HEAD)
> Author: Luke Kenneth Casson Leighton <lkcl at lkcl.net>
> Date:   Mon Nov 6 02:46:09 2023 +0000
> 
>     rename pifpstore instructions, add "p" into names

thanks, though I already made a commit fixing that (and all the other files) on
the programmerjake/bug-1177 branch, I just hadn't pushed it yet (sorry):
https://git.libre-soc.org/?p=openpower-isa.git;a=commitdiff;h=5a2cd34ab850aa388cd381ff73ea5bbc5c92cdce

-- 
You are receiving this mail because:
You are on the CC list for the bug.