[Libre-soc-bugs] [Bug 1177] revert unauthorized change to pseudocode language

bugzilla-daemon at libre-soc.org bugzilla-daemon at libre-soc.org
Thu Nov 2 07:08:28 GMT 2023


--- Comment #14 from Luke Kenneth Casson Leighton <lkcl at lkcl.net> ---
         # XXX TODO: allow CR-vector to be written out even if ffirst fails
         if not ffirst_hit or vli:
             for name, output in outs.items():
-                yield from self.check_write(info, name, output, ca_en, ew_dst)
+                out_ok = outs_ok[name]
+                yield from self.check_write(
+                    info, name, output, ca_en, ew_dst, out_ok)

ok i went to some trouble to ensure that the number of arguments
was below 80 chars to avoid this type of indentation. it is
"not clean or clear" (visual noise)

there will only ever be one call to check_write.
can you please kindly put that back the way it was, and use:

        if not outs_ok[name]:
           log("skipping writing output with .ok=False", name, output)
        yield from self.check_write(info, name, output, ca_en, ew_dst)

it achieves the same effect with less noise and less lines. reduce the words in
the log call to get it to stay on one line.
(this code is so complex a Finite State Machine that it *has* to remain
"uncluttered", both visually and functionally, with REALLY clear comments).

You are receiving this mail because:
You are on the CC list for the bug.

More information about the libre-soc-bugs mailing list