[Libre-soc-bugs] [Bug 1177] revert unauthorized change to pseudocode language

bugzilla-daemon at libre-soc.org bugzilla-daemon at libre-soc.org
Thu Nov 2 02:03:11 GMT 2023


--- Comment #12 from Jacob Lifshay <programmerjake at gmail.com> ---
(In reply to Luke Kenneth Casson Leighton from comment #11)
> (In reply to Jacob Lifshay from comment #10)
> > ok, yeah, that would work. I didn't initially pick that since I really think
> > SelectableInt should just be a bit-string with nothing else...
> abolutely not.
> performance is low enough as it is.

I don't see how that affects performance.

> no because it matches the HDL which already has precedet. and is short.
> ensure that the comment links here and also says "this matches the HDL
> it is a stupid name" or something more appropriate but explicitly clear.

I just added docs for all SelectableInt fields (except overflow, cuz I forgot):
    value: int
        the bits contained by `self`
    bits: int
        the number of bits contained by `self`.
    ok: bool
        a flag to detect if outputs have been written by pseudo-code

        instruction inputs have `ok` set to `False`, all changed or new
        SelectableInt instances set `ok` to `True`.


rebased programmerjake/bug-1177 on master:

commit afa6db74d7dca5ccb83e1186a0f49c85bf810921
Author: Jacob Lifshay <programmerjake at gmail.com>
Date:   Wed Nov 1 18:51:23 2023 -0700

    WIP fixing bug #1177

commit ffc3710214a7c4828f994fddffcba6f4383603ac
Author: Jacob Lifshay <programmerjake at gmail.com>
Date:   Wed Nov 1 18:36:10 2023 -0700

    format code

commit 370b69a982df2dbfba3675e4a3a2f998555df1db
Author: Jacob Lifshay <programmerjake at gmail.com>
Date:   Tue Oct 31 22:50:40 2023 -0700

    misc AST correctness fixes

I dropped the fallthrough commit, since that needs a better fix: bug #1197

You are receiving this mail because:
You are on the CC list for the bug.

More information about the libre-soc-bugs mailing list