[Libre-soc-bugs] [Bug 1177] revert unauthorized change to pseudocode language

bugzilla-daemon at libre-soc.org bugzilla-daemon at libre-soc.org
Wed Nov 1 21:51:50 GMT 2023


--- Comment #10 from Jacob Lifshay <programmerjake at gmail.com> ---
(In reply to Luke Kenneth Casson Leighton from comment #9)
> ok. it can be done by setting all "ok" flags in all inputs
> to FALSE, followed by modifying SelectableInt to set
> data.ok=True in its constructor and in all math operations.

ok, yeah, that would work. I didn't initially pick that since I really think
SelectableInt should just be a bit-string with nothing else...but it is the
easiest place to put it.

I think it shouldn't be named `ok` tho, I think we need to pick a name that
makes sense and when you first see it you don't need to look at the docs to
figure out what it means (since people often don't). I think I'll use `touched`
since what we really want to detect is if the variable hasn't been written or
replaced. touched will be set by all operations that produce a SelectableInt,
including copies.

> FieldSelectableInt is not necessary as we never return FSI from
> any operations. but worth keeping an eye on.

FieldSelectableInt is converted to SelectableInt by copy_assign_rhs anyway...we
don't want:
a <- b[3:5]
a[1] <- 0  # modifies b too

You are receiving this mail because:
You are on the CC list for the bug.

More information about the libre-soc-bugs mailing list