[Libre-soc-bugs] [Bug 713] PartitionedSignal enhancement to add partition-context-aware lengths

[bugzilla-daemon at libre-soc.org]

https://bugs.libre-soc.org/show_bug.cgi?id=713

--- Comment #77 from Jacob Lifshay <programmerjake at gmail.com> ---
(In reply to Luke Kenneth Casson Leighton from comment #75)
> arrgh, ok now i understand what's going on, it's possible to identify
> that this is fundamentally broken:
> 
>     # compute a set of partition widths
>     cpart_wid = [-lane_shapes[i] // c for i, c in part_counts.items()]
>     print ("cpart_wid", cpart_wid, "part_counts", part_counts)
>     cpart_wid = -min(cpart_wid)
> 
> for the example given 
> 
>     part_counts {0: 1, 1: 1, 2: 2, 3: 4}
>     widths_at_elwidth = { 0: 5, 1: 6, 2: 12, 3: 24}
> 
> it creates:
> 
>     cpart_wid [-5, -6, -6, -6] 
> 
> and produces a minimum of 5 for cpart_wid.

no, it produces a minimum of -6, since -6 is less than -5.

-- 
You are receiving this mail because:
You are on the CC list for the bug.