[Libre-soc-bugs] [Bug 745] OP_TERNARY instruction

bugzilla-daemon at libre-soc.org bugzilla-daemon at libre-soc.org
Thu Nov 25 01:55:05 GMT 2021


--- Comment #19 from Jacob Lifshay <programmerjake at gmail.com> ---
(In reply to Luke Kenneth Casson Leighton from comment #18)
> https://git.libre-soc.org/?p=nmutil.git;a=blob;f=src/nmutil/test/test_lut.py;h=14896da28d3eff637048c746d1e7a2aa5865f133;hb=892a3cd2f7d76a842c9f838d808af70ea87bf7f6#l33
> jacob could you please remove that code entirely and use the standard
> FHDLTestCase class just like all other formal correctness proofs,
> which you should have known existed because you must have been
> reading the source code and constantly examining it for over 2 years
> now, so there is no excuse.

Yeah, I can switch back, though FHDLTestCase has some serious shortcomings,
including not working correctly when tests are run in parallel cuz it uses the
same directory (fixed by formal's using get_test_path which uses a separate
path for each test case fn as well as each time it's called in a single test
fn), as well as breaking the API of the assertRaises, assertRaisesRegex, and
assertWarns methods (cuz they yield None rather than what they should).
> again this is unnecessary duplicated code which has been written
> and precious time has been wasted on more duplication,

it took me all of 30s to copy from where I already wrote it for unrelated code,
so basically zero time was spent in that particular aspect.

> then more
> time spent identifying the duplication, then more time asking you
> to remove the duplication, and more time by you spent removing the
> duplication.

yeah, yeah...

I'll be busy for the rest of today and tomorrow, so will get to it on friday.

You are receiving this mail because:
You are on the CC list for the bug.

More information about the libre-soc-bugs mailing list