[Libre-soc-bugs] [Bug 565] Improve formal verification on PartitionedSignal

bugzilla-daemon at libre-soc.org bugzilla-daemon at libre-soc.org
Sat Jan 23 19:23:18 GMT 2021


https://bugs.libre-soc.org/show_bug.cgi?id=565

--- Comment #38 from Cesar Strauss <cestrauss at gmail.com> ---
(In reply to Luke Kenneth Casson Leighton from comment #34)
> (In reply to Cesar Strauss from comment #33)
> > (In reply to Luke Kenneth Casson Leighton from comment #32)
> yep that is a bug, it should be return PartitionedSignal(~self.sig,
> self.partpoints)

It doesn't work that way, exactly. PartitionedSignal's __init__() doesn't wrap
around a nMigen expression.

It must be:

    result = PartitionedSignal(self.partpoints, self.sig.width)
    self.m.d.comb += result.sig.eq(~self.sig)
    return result

Could be simplified a bit by implementing result =
PartitionedSignal.like(self).

What do you think? Is there a way to do it the way you described?

-- 
You are receiving this mail because:
You are on the CC list for the bug.


More information about the libre-soc-bugs mailing list