[Libre-soc-bugs] [Bug 745] OP_TERNLOG instruction

bugzilla-daemon at libre-soc.org bugzilla-daemon at libre-soc.org
Fri Dec 17 23:21:56 GMT 2021


https://bugs.libre-soc.org/show_bug.cgi?id=745

--- Comment #52 from Luke Kenneth Casson Leighton <lkcl at lkcl.net> ---
(In reply to Jacob Lifshay from comment #51)

> They do get used pretty often:
> https://repo.or.cz/docutils.git/blob/
> 3c60c830ac4cafaede096539d09c45f51544686a:/docutils/docutils/transforms/
> frontmatter.py#l382
> 
> https://github.com/pdoc3/pdoc/blob/4aa70de2221a34a3003a7e5f52a9b91965f0e359/
> pdoc/__init__.py#L502

blech :)

> Also, probably most importantly, they're the format that basically *all*
> tools understand, sphinx/docutils, pdoc3, vscode, etc.

very true.  i also deduced why they must have done post-docstring, because
that's what's done on functions and classes.  the docstring comes directly
after the function declaration or class declaration [it's still "blech" :) ]

i know what it was: the lack of space between them

inputs = ...
"""the inputs"""
outputs = ....
"""the outputs"""

etc. this just confused the hell out of me.  i tried restoring the docstrings
and adding some extra spaces and it just irritated me that there was extra
space, given that it becomes nine (9!!) lines instead of three (3).

this by contrast is compact, clear, and fits in under 80 chars

+        self.inputs = tuple(inp(i) for i in range(input_count)) # inputs
+        self.lut = Signal(2 ** input_count)                     # lookup input
+        self.output = Signal(width)                             # output

-- 
You are receiving this mail because:
You are on the CC list for the bug.


More information about the libre-soc-bugs mailing list