[Libre-soc-bugs] [Bug 745] OP_TERNLOG instruction

[bugzilla-daemon at libre-soc.org]

https://bugs.libre-soc.org/show_bug.cgi?id=745

--- Comment #47 from Luke Kenneth Casson Leighton <lkcl at lkcl.net> ---
(In reply to Jacob Lifshay from comment #46)
> (In reply to Luke Kenneth Casson Leighton from comment #45)
> I simplified the code and added docs.

nice.  it's tidy and consistent. looks great.  ah, just spotted:

* missing copyright notice
* using php-style functions-inside-text (blech!)
* spaces in front of docstrings (i know, it looks untidy, but that's
  the style)
* although saying "see BitwiseLUT docstring" is fine in this case
  (because the API is identical), actually saying *that* the API
  is identical (and why) is missing.

> No, self.lut is an *input*, it would break if I had it private.

that would be why it would need to have been documented :)

-- 
You are receiving this mail because:
You are on the CC list for the bug.