[Libre-soc-bugs] [Bug 550] binutils support needed for svp64
bugzilla-daemon at libre-soc.org
bugzilla-daemon at libre-soc.org
Mon Dec 13 19:09:26 GMT 2021
https://bugs.libre-soc.org/show_bug.cgi?id=550
--- Comment #37 from dmitry.selyutin at 3mdeb.com ---
(In reply to Luke Kenneth Casson Leighton from comment #35)
> it looks really good: the only thing that's a little odd is:
>
> +static char *
> +svp64_decode_ff_or_pr(char *str, int *value)
> so only RC1 or ~RC1
>
> other than that it looks really good.
In Python, the function returns either int or str, which looks kinda bad for C;
instead of this, I added special values, -1 and -2, corresponding to RC1 and
~RC1. These are handled specially. The exact equivalent of Python code looks
quite unorthodox to me; I'm open to suggestions on how to implement it better
(including the function name and the semantics). For starters, I'll split the
routine svp64_decode_ff_or_pr into two, where one is svp64_decode_bo.
--
You are receiving this mail because:
You are on the CC list for the bug.
More information about the libre-soc-bugs
mailing list