[Libre-soc-bugs] [Bug 745] OP_TERNLOG instruction

[bugzilla-daemon at libre-soc.org]

https://bugs.libre-soc.org/show_bug.cgi?id=745

--- Comment #45 from Luke Kenneth Casson Leighton <lkcl at lkcl.net> ---
just going over lut.py:

delete these. again they are unnecessary and violate LSP

  29         assert isinstance(input_count, int)
  30         assert isinstance(width, int)

all of these can go

  40         def lut_index(i):
  41             return Signal(input_count, name=f"lut_index_{i}")
  42         self._lut_indexes = [lut_index(i) for i in range(width)]

insert this between 47 and 48


  47         for i in range(self.width):
                 lut_idx = Signal(input_count, name=f"lut_index_{i}")
  48             for j in range(self.input_count):

remove self. in front of lut_idx

also remove self. on front of lut and move into elaborate
where self. is also removed.

  38         self.lut = Signal(2 ** input_count)

the style that you are using is exposing private local signals
unnecessarily.


because this is a public library, there are not enough code-comments.
as with grev.py:

* link to bugreport
* add explicit copyright and link to NLnet and NGI POINTER
* """docstring what the module does"""
* explanatory comments

-- 
You are receiving this mail because:
You are on the CC list for the bug.