[Libre-soc-bugs] [Bug 50] nmigen pinmux

bugzilla-daemon at libre-soc.org bugzilla-daemon at libre-soc.org
Thu Dec 2 11:58:16 GMT 2021


https://bugs.libre-soc.org/show_bug.cgi?id=50

--- Comment #64 from Luke Kenneth Casson Leighton <lkcl at lkcl.net> ---
        gpio_oe_test = Signal(num_gpios)
        # Wire up the output signal of each gpio by XOR'ing each bit of g
pio_o_test with gpio's input
        # Wire up each bit of gpio_oe_test signal to oe signal of each gpio. 
        # Turn into a loop at some point, probably a way without
        # using get_attr()

PEP-8.  do keep comments (actually, all lines) to under 80 chars

if you must insist on wasting screen real-estate by running editors in
windows of greater than 80 chars in size then add a "guide line" at
80 chars.  it is better to fix the terminal width *at* 80 chars which
has the result of making the code look immediately and obviously s***,
like this:

https://ftp.libre-soc.org/2021-12-02_11-55.png

you can install and run pep8checker and even autopep8 to in-place sort
these things, but if you do *please run it as a separate commit*
with the comment "whitespace" or "autopep8 run"

-- 
You are receiving this mail because:
You are on the CC list for the bug.


More information about the libre-soc-bugs mailing list